Hackpad

Hey man nice hackpad i like the hackclub and github emboss on the CAD but there are some stuff that needs revision before I can approve this.
Firstly you have no production folder in your repo please add a production folder with all the individual .step files that needs to be printed as well as the gerbers.zip, and the firmware.
Now coming to the CAD you have no proper enclosure like I see the case but it just exposes the PCB... you should have a plate over the enclosure that you screw with the case. Here's an side by side comparison of how it should be done. The guide clearly states you must have a two part case atleast, and u can still expose pcb like the orpheus pad does :]
Now your PCB the routing can surely benefit from a rerouting because I see a couple 90 degree angle turns which can be problematic at time so I recommend you make sure each turn is 45 degrees. You also connected all the VCC/3.3v and the GND using normal routing, I recommend you use a filled zone for this instead or use thicker traces. Also all the borders of your keys intersect each other even though the pads dont intersect its just the border but its not ideal and i would like you to properly arrange your keycaps or it may cause difficulties in assembly.
Now coming to the firmware there are some missing source files like keymap.c, there are also some naming errors like u have rules.mk.mk and config.h.c which actually should be rules.mk and config.h. Also please add a .uf2 file in your production folder so anyone can instantly flash it without setting up QMK.
There's also no BOM.csv file in your repo so please add that too and redo your readme add some details like what software you used how is the whole thing assembled, why you made it etc.

Reviewer feedback

×

@Nemo_Donut left feedback · 17 days ago

Hey man nice hackpad i like the hackclub and github emboss on the CAD but there are some stuff that needs revision before I can approve this.
Firstly you have no production folder in your repo please add a production folder with all the individual .step files that needs to be printed as well as the gerbers.zip, and the firmware.
Now coming to the CAD you have no proper enclosure like I see the case but it just exposes the PCB... you should have a plate over the enclosure that you screw with the case. Here's an side by side comparison of how it should be done. The guide clearly states you must have a two part case atleast, and u can still expose pcb like the orpheus pad does :]
Now your PCB the routing can surely benefit from a rerouting because I see a couple 90 degree angle turns which can be problematic at time so I recommend you make sure each turn is 45 degrees. You also connected all the VCC/3.3v and the GND using normal routing, I recommend you use a filled zone for this instead or use thicker traces. Also all the borders of your keys intersect each other even though the pads dont intersect its just the border but its not ideal and i would like you to properly arrange your keycaps or it may cause difficulties in assembly.
Now coming to the firmware there are some missing source files like keymap.c, there are also some naming errors like u have rules.mk.mk and config.h.c which actually should be rules.mk and config.h. Also please add a .uf2 file in your production folder so anyone can instantly flash it without setting up QMK.
There's also no BOM.csv file in your repo so please add that too and redo your readme add some details like what software you used how is the whole thing assembled, why you made it etc.