So one of the maintainers left a comment with feedback for what I should do about 2 days ago. Today I finished addressing those issues in code.
ㅤ
The reason it took this long is because I was legit just spending 2 hours or so just wondering what I should do! Basically, the other PR that was about the calendar system I mentioned earlier got merged and made the ICS parsing function take in a C++ std::stop_token, which I was unfamiliar with.
It turns out that it has to do with multi-threading and so I had a dilemma of whether I should make it parse the calendar data in a separate thread or not. I at first decided to make it multi-threaded but then changed my mind when I realized how hard it would be.
ㅤ
There is a lot more to this though, if you are curious you can see more details in my PR comment.
ㅤ
Also here’s a proper video of this feature in action!
Comments 0
No comments yet. Be the first!
Sign in to join the conversation.