Today I fixed almost all the feedback my reviewer gave for ASTRA. But if you be little more specific I think it will be much more helpful for me.I started with the security issue where room name was using innerHTML, so now I changed it to textContent and createElement so even if someone types script tag it just shows as text 😅 Then I fixed fav color which was totally useless before I made a proper hexToHsl function (so now pink is 320-360°) blue is pure (210-250°) not cyan ands green is( 80-150°) etc and it actually gives points to matching styles and tints the whole UI. Photo analysis was the biggest fix 📸 before it just stretched image to 80x80, now I do proper cover crop so aspect ratio stays, and I set onload BEFORE src so it never fails, plus added onerror for corrupted files ⚠️. I also filtered out white walls by skipping bright pixels.I changed wishlist div to real button so Enter or space works naturally, added proper for labels for roomname and favcolor, and added visible focus outlines.Also tested dark room photo, plant photo, XSS test, keyboard tabbing . All of this for today (! !).
Comments 0
No comments yet. Be the first!
Sign in to join the conversation.