We might finally get a new maintainer to actually review my code! I fear that he’s using AI to write sentences, though… I really hope his code isn’t AI.
At least it seems that it isn’t, because he’s overcomplicating things. He correctly pointed out that the form LLU instead of ULL is also often used as a literal suffix (that we would need to detect) and that the insensitivity should be an inline group instead of flag, but then came up with this monstrosity: (?i:(?:U(?:LL?)?|(?:LL?)U?)?). I confirmed that the more orthodox (?i:U|UL|ULL|L|LL|LU|LLU) was faster (and readable!), that (?i) is a real thing (wow! thanks pythoma), ran tests, and committed the changes straight from GitHub after spending way too much time figuring out how the PR tab in PyCharm worked. An overcomplication to end an exploration of overcomplications.
Comments 0
No comments yet. Be the first!
Sign in to join the conversation.