I fixed an issue where socket fds were leaked, which caused the helper to eventually stop serving the static webapp due to an fd limit. I thought I fixed it by closing the websocket after it stopped being able to receive, but this would only happen if the websocket was already closed by the runner, meaning the call to close the websocket would always fail. I originally thought that because I reconnected in a loop, the websocket object would get dropped per iteration, but maybe due to async, it didn’t. So, to ensure the OS socket is closed, I manually drop the websocket object after recv fails.
Comments 0
No comments yet. Be the first!
Sign in to join the conversation.